Hackerrank All Women's Codesprint 2019: Name the ProductMaximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors
Is xar preinstalled on macOS?
Is there any common country to visit for uk and schengen visa?
What kind of footwear is suitable for walking in micro gravity environment?
What is 露わになる affecting in the following sentence, '才能の持ち主' (持ち主 to be specific) or '才能'?
Is VPN a layer 3 concept?
Can a university suspend a student even when he has left university?
Is this Pascal's Matrix?
Print last inputted byte
Weird lines in Microsoft Word
If I cast the Enlarge/Reduce spell on an arrow, what weapon could it count as?
Why didn’t Eve recognize the little cockroach as a living organism?
Do I need to convey a moral for each of my blog post?
UK Tourist Visa- Enquiry
PTIJ: Which Dr. Seuss books should one obtain?
What is it called when someone votes for an option that's not their first choice?
When did hardware antialiasing start being available?
What are the rules for concealing thieves' tools (or items in general)?
Why is participating in the European Parliamentary elections used as a threat?
Single word to change groups
Homology of the fiber
Does convergence of polynomials imply that of its coefficients?
Should I be concerned about student access to a test bank?
Have any astronauts/cosmonauts died in space?
Why do I have a large white artefact on the rendered image?
Hackerrank All Women's Codesprint 2019: Name the Product
Maximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors
$begingroup$
Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/
Problem
You are contesting to name a new product in your company given the following conditions:
You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.
You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.
Note: If there are many such names chose the lexicographically largest one.
Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.
Function Description
Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.
productName has the following parameter(s):
names: array of $n$ names
Input Format
- The first line contains an integer, $n$, denoting the number of elements in $names$.
- Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.
Constraints
- $1 le n le 10^5$
- All characters in the names are lowercase English alphabets.
- Each name is of length $5$.
Output Format
- The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.
Sample Input 0
3
bubby
bunny
berry
Sample Output 0
zzzzz
Explanation 0
- Difference between $names_0$, bubby, and zzzzz is $5$.
- Difference between $names_1$, bunny, and zzzzz is $5$.
- Difference between $names_2$, berry, and zzzzz is $5$.
So, total difference is 15, which is maximal.
Sample Input 1
3
ready
stedy
zebra
Sample Output 1
yzzzz
Explanation 1
- Difference between $names_0$, ready, and yzzzz is $5$.
- Difference between $names_1$, stedy, and yzzzz is $5$.
- Difference between $names_2$, zebra, and yzzzz is $5$.
So, total differce is 15, which is maximal.
I would strip the extraneous parts from my solution:
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))
I'm concerned with adhering to best practices and maximising performance.
python performance beginner programming-challenge
$endgroup$
|
show 1 more comment
$begingroup$
Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/
Problem
You are contesting to name a new product in your company given the following conditions:
You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.
You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.
Note: If there are many such names chose the lexicographically largest one.
Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.
Function Description
Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.
productName has the following parameter(s):
names: array of $n$ names
Input Format
- The first line contains an integer, $n$, denoting the number of elements in $names$.
- Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.
Constraints
- $1 le n le 10^5$
- All characters in the names are lowercase English alphabets.
- Each name is of length $5$.
Output Format
- The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.
Sample Input 0
3
bubby
bunny
berry
Sample Output 0
zzzzz
Explanation 0
- Difference between $names_0$, bubby, and zzzzz is $5$.
- Difference between $names_1$, bunny, and zzzzz is $5$.
- Difference between $names_2$, berry, and zzzzz is $5$.
So, total difference is 15, which is maximal.
Sample Input 1
3
ready
stedy
zebra
Sample Output 1
yzzzz
Explanation 1
- Difference between $names_0$, ready, and yzzzz is $5$.
- Difference between $names_1$, stedy, and yzzzz is $5$.
- Difference between $names_2$, zebra, and yzzzz is $5$.
So, total differce is 15, which is maximal.
I would strip the extraneous parts from my solution:
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))
I'm concerned with adhering to best practices and maximising performance.
python performance beginner programming-challenge
$endgroup$
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
11
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
2
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
3
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago
|
show 1 more comment
$begingroup$
Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/
Problem
You are contesting to name a new product in your company given the following conditions:
You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.
You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.
Note: If there are many such names chose the lexicographically largest one.
Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.
Function Description
Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.
productName has the following parameter(s):
names: array of $n$ names
Input Format
- The first line contains an integer, $n$, denoting the number of elements in $names$.
- Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.
Constraints
- $1 le n le 10^5$
- All characters in the names are lowercase English alphabets.
- Each name is of length $5$.
Output Format
- The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.
Sample Input 0
3
bubby
bunny
berry
Sample Output 0
zzzzz
Explanation 0
- Difference between $names_0$, bubby, and zzzzz is $5$.
- Difference between $names_1$, bunny, and zzzzz is $5$.
- Difference between $names_2$, berry, and zzzzz is $5$.
So, total difference is 15, which is maximal.
Sample Input 1
3
ready
stedy
zebra
Sample Output 1
yzzzz
Explanation 1
- Difference between $names_0$, ready, and yzzzz is $5$.
- Difference between $names_1$, stedy, and yzzzz is $5$.
- Difference between $names_2$, zebra, and yzzzz is $5$.
So, total differce is 15, which is maximal.
I would strip the extraneous parts from my solution:
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))
I'm concerned with adhering to best practices and maximising performance.
python performance beginner programming-challenge
$endgroup$
Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/
Problem
You are contesting to name a new product in your company given the following conditions:
You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.
You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.
Note: If there are many such names chose the lexicographically largest one.
Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.
Function Description
Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.
productName has the following parameter(s):
names: array of $n$ names
Input Format
- The first line contains an integer, $n$, denoting the number of elements in $names$.
- Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.
Constraints
- $1 le n le 10^5$
- All characters in the names are lowercase English alphabets.
- Each name is of length $5$.
Output Format
- The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.
Sample Input 0
3
bubby
bunny
berry
Sample Output 0
zzzzz
Explanation 0
- Difference between $names_0$, bubby, and zzzzz is $5$.
- Difference between $names_1$, bunny, and zzzzz is $5$.
- Difference between $names_2$, berry, and zzzzz is $5$.
So, total difference is 15, which is maximal.
Sample Input 1
3
ready
stedy
zebra
Sample Output 1
yzzzz
Explanation 1
- Difference between $names_0$, ready, and yzzzz is $5$.
- Difference between $names_1$, stedy, and yzzzz is $5$.
- Difference between $names_2$, zebra, and yzzzz is $5$.
So, total differce is 15, which is maximal.
I would strip the extraneous parts from my solution:
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))
I'm concerned with adhering to best practices and maximising performance.
python performance beginner programming-challenge
python performance beginner programming-challenge
asked 16 hours ago
Tobi AlafinTobi Alafin
635110
635110
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
11
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
2
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
3
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago
|
show 1 more comment
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
11
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
2
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
3
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
11
11
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
2
2
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
3
3
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago
|
show 1 more comment
1 Answer
1
active
oldest
votes
$begingroup$
Imports
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
Seriously, don't do this. It may be useful to read PEP8 regarding imports again.
- Imports should be on separate lines.
Why do
Counter as count
? It impairs readability.Especially in larger scripts, every Python dev knows
Counter
, butcount
could be a random variable and is easy to be overshadowed.You don't use all of the imported modules; just remove them if you don't need them.
alphabet = "abcdefghijklmnopqrstuvwxyz"
Here you missed something that is in the standard lib:
from string import ascii_lowercase
Misc
This
dd(lambda: 0, ...
adds no valueCounter is already a dictionary with
default value 0
just remove that partMagic numbers
5
is a Magic number, you should define it as a CONSTANT:NAME_LENGTH = 5
The rest looks good!
$endgroup$
6
$begingroup$
May as well avoid aliasingdefaultdict
, too. Who the heck is going to know whatdd
is if they skip past the imports?
$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
$begingroup$
Respectfully no, the same advice goes for aliasingdefaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
8 hours ago
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
|
show 1 more comment
Your Answer
StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
Imports
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
Seriously, don't do this. It may be useful to read PEP8 regarding imports again.
- Imports should be on separate lines.
Why do
Counter as count
? It impairs readability.Especially in larger scripts, every Python dev knows
Counter
, butcount
could be a random variable and is easy to be overshadowed.You don't use all of the imported modules; just remove them if you don't need them.
alphabet = "abcdefghijklmnopqrstuvwxyz"
Here you missed something that is in the standard lib:
from string import ascii_lowercase
Misc
This
dd(lambda: 0, ...
adds no valueCounter is already a dictionary with
default value 0
just remove that partMagic numbers
5
is a Magic number, you should define it as a CONSTANT:NAME_LENGTH = 5
The rest looks good!
$endgroup$
6
$begingroup$
May as well avoid aliasingdefaultdict
, too. Who the heck is going to know whatdd
is if they skip past the imports?
$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
$begingroup$
Respectfully no, the same advice goes for aliasingdefaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
8 hours ago
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
|
show 1 more comment
$begingroup$
Imports
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
Seriously, don't do this. It may be useful to read PEP8 regarding imports again.
- Imports should be on separate lines.
Why do
Counter as count
? It impairs readability.Especially in larger scripts, every Python dev knows
Counter
, butcount
could be a random variable and is easy to be overshadowed.You don't use all of the imported modules; just remove them if you don't need them.
alphabet = "abcdefghijklmnopqrstuvwxyz"
Here you missed something that is in the standard lib:
from string import ascii_lowercase
Misc
This
dd(lambda: 0, ...
adds no valueCounter is already a dictionary with
default value 0
just remove that partMagic numbers
5
is a Magic number, you should define it as a CONSTANT:NAME_LENGTH = 5
The rest looks good!
$endgroup$
6
$begingroup$
May as well avoid aliasingdefaultdict
, too. Who the heck is going to know whatdd
is if they skip past the imports?
$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
$begingroup$
Respectfully no, the same advice goes for aliasingdefaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
8 hours ago
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
|
show 1 more comment
$begingroup$
Imports
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
Seriously, don't do this. It may be useful to read PEP8 regarding imports again.
- Imports should be on separate lines.
Why do
Counter as count
? It impairs readability.Especially in larger scripts, every Python dev knows
Counter
, butcount
could be a random variable and is easy to be overshadowed.You don't use all of the imported modules; just remove them if you don't need them.
alphabet = "abcdefghijklmnopqrstuvwxyz"
Here you missed something that is in the standard lib:
from string import ascii_lowercase
Misc
This
dd(lambda: 0, ...
adds no valueCounter is already a dictionary with
default value 0
just remove that partMagic numbers
5
is a Magic number, you should define it as a CONSTANT:NAME_LENGTH = 5
The rest looks good!
$endgroup$
Imports
import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count
Seriously, don't do this. It may be useful to read PEP8 regarding imports again.
- Imports should be on separate lines.
Why do
Counter as count
? It impairs readability.Especially in larger scripts, every Python dev knows
Counter
, butcount
could be a random variable and is easy to be overshadowed.You don't use all of the imported modules; just remove them if you don't need them.
alphabet = "abcdefghijklmnopqrstuvwxyz"
Here you missed something that is in the standard lib:
from string import ascii_lowercase
Misc
This
dd(lambda: 0, ...
adds no valueCounter is already a dictionary with
default value 0
just remove that partMagic numbers
5
is a Magic number, you should define it as a CONSTANT:NAME_LENGTH = 5
The rest looks good!
edited 15 hours ago
Toby Speight
26.4k742118
26.4k742118
answered 15 hours ago
LudisposedLudisposed
8,83422267
8,83422267
6
$begingroup$
May as well avoid aliasingdefaultdict
, too. Who the heck is going to know whatdd
is if they skip past the imports?
$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
$begingroup$
Respectfully no, the same advice goes for aliasingdefaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
8 hours ago
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
|
show 1 more comment
6
$begingroup$
May as well avoid aliasingdefaultdict
, too. Who the heck is going to know whatdd
is if they skip past the imports?
$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
$begingroup$
Respectfully no, the same advice goes for aliasingdefaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
8 hours ago
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
6
6
$begingroup$
May as well avoid aliasing
defaultdict
, too. Who the heck is going to know what dd
is if they skip past the imports?$endgroup$
– jpmc26
8 hours ago
$begingroup$
May as well avoid aliasing
defaultdict
, too. Who the heck is going to know what dd
is if they skip past the imports?$endgroup$
– jpmc26
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
8 hours ago
5
5
$begingroup$
Respectfully no, the same advice goes for aliasing
defaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***$endgroup$
– Ludisposed
8 hours ago
$begingroup$
Respectfully no, the same advice goes for aliasing
defaultdict
. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***$endgroup$
– Ludisposed
8 hours ago
3
3
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
6 hours ago
2
2
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
6 hours ago
|
show 1 more comment
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
16 hours ago
11
$begingroup$
Absolutely not.
$endgroup$
– Mast
16 hours ago
2
$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
16 hours ago
$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
16 hours ago
3
$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
14 hours ago