Passing args from the bash script to the function in the scriptAre there naming conventions for variables in shell scripts?When is double-quoting necessary?How can we run a command stored in a variable?Passing a stream to a bash functionPassing script string to ssh from within a bash script function - variable evaluation problembash script - loop functionShell script - command always display usage before executingrsync using function argsBash script inheritance? Calling a function from another script?Passing options/args/parameters with spaces from the script to a function withinPassing a boolean flag to a function?Dynamically read bash function name from inside bash functionrunning bash script from cron job not working properly

Does jamais mean always or never in this context?

Binary Numbers Magic Trick

What's the metal clinking sound at the end of credits in Avengers: Endgame?

Help, my Death Star suffers from Kessler syndrome!

How to determine the actual or "true" resolution of a digital photograph?

What is a Recurrent Neural Network?

What's the polite way to say "I need to urinate"?

Confused by notation of atomic number Z and mass number A on periodic table of elements

Transfer over $10k

What is the range of this combined function?

Is GOCE a satellite or aircraft?

In Proverbs 14:34, is sin a disgrace to a people, or is mercy a sin-offering?

Why does nature favour the Laplacian?

Stark VS Thanos

gnu parallel how to use with ffmpeg

How to stop co-workers from teasing me because I know Russian?

Can fracking help reduce CO2?

Why do Ichisongas hate elephants and hippos?

Any examples of headwear for races with animal ears?

Pressure to defend the relevance of one's area of mathematics

Are Boeing 737-800’s grounded?

If Earth is tilted, why is Polaris always above the same spot?

Has any spacecraft ever had the ability to directly communicate with civilian air traffic control?

Modify locally tikzset



Passing args from the bash script to the function in the script


Are there naming conventions for variables in shell scripts?When is double-quoting necessary?How can we run a command stored in a variable?Passing a stream to a bash functionPassing script string to ssh from within a bash script function - variable evaluation problembash script - loop functionShell script - command always display usage before executingrsync using function argsBash script inheritance? Calling a function from another script?Passing options/args/parameters with spaces from the script to a function withinPassing a boolean flag to a function?Dynamically read bash function name from inside bash functionrunning bash script from cron job not working properly






.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








3















My script:



#! /bin/bash --

set -x

## docker-compose wrapper
compose_fn()
local ENV="$1"
local VERB="$2"
local SERVICE="$3"
local CMD="docker-compose -f $ENV.yml"
case "$VERB" in
(exec)
shift "$#" # remove args passed to this fn
# Execute a command in a running container.
if [ -n "$SERVICE" ]; then
$CMD "$VERB" "$SERVICE" "$@"
else
echo "## Err: You must specify service name..."
exit 1
fi
;;
esac


compose_fn "$1" "$2" "$3"


Is giving me a hard time with the following error:



$ ./tst.sh dev exec django sh
+ compose_fn dev exec django
+ local ENV=dev
+ local VERB=exec
+ local SERVICE=django
+ local 'CMD=docker-compose -f dev.yml'
+ case "$VERB" in
+ shift 3
+ '[' -n django ']'
+ docker-compose -f dev.yml exec django
Execute a command in a running container

Usage: exec [options] [-e KEY=VAL...] SERVICE COMMAND [ARGS...]

Options:
....


Where is my mistake? How can it be done better?



As far as I can tell I've passed 4 args [dev, exec, django, sh] to the script, then within the script removed 3 (shift 3), therefore sh should have been left in the $@ var.










share|improve this question






























    3















    My script:



    #! /bin/bash --

    set -x

    ## docker-compose wrapper
    compose_fn()
    local ENV="$1"
    local VERB="$2"
    local SERVICE="$3"
    local CMD="docker-compose -f $ENV.yml"
    case "$VERB" in
    (exec)
    shift "$#" # remove args passed to this fn
    # Execute a command in a running container.
    if [ -n "$SERVICE" ]; then
    $CMD "$VERB" "$SERVICE" "$@"
    else
    echo "## Err: You must specify service name..."
    exit 1
    fi
    ;;
    esac


    compose_fn "$1" "$2" "$3"


    Is giving me a hard time with the following error:



    $ ./tst.sh dev exec django sh
    + compose_fn dev exec django
    + local ENV=dev
    + local VERB=exec
    + local SERVICE=django
    + local 'CMD=docker-compose -f dev.yml'
    + case "$VERB" in
    + shift 3
    + '[' -n django ']'
    + docker-compose -f dev.yml exec django
    Execute a command in a running container

    Usage: exec [options] [-e KEY=VAL...] SERVICE COMMAND [ARGS...]

    Options:
    ....


    Where is my mistake? How can it be done better?



    As far as I can tell I've passed 4 args [dev, exec, django, sh] to the script, then within the script removed 3 (shift 3), therefore sh should have been left in the $@ var.










    share|improve this question


























      3












      3








      3








      My script:



      #! /bin/bash --

      set -x

      ## docker-compose wrapper
      compose_fn()
      local ENV="$1"
      local VERB="$2"
      local SERVICE="$3"
      local CMD="docker-compose -f $ENV.yml"
      case "$VERB" in
      (exec)
      shift "$#" # remove args passed to this fn
      # Execute a command in a running container.
      if [ -n "$SERVICE" ]; then
      $CMD "$VERB" "$SERVICE" "$@"
      else
      echo "## Err: You must specify service name..."
      exit 1
      fi
      ;;
      esac


      compose_fn "$1" "$2" "$3"


      Is giving me a hard time with the following error:



      $ ./tst.sh dev exec django sh
      + compose_fn dev exec django
      + local ENV=dev
      + local VERB=exec
      + local SERVICE=django
      + local 'CMD=docker-compose -f dev.yml'
      + case "$VERB" in
      + shift 3
      + '[' -n django ']'
      + docker-compose -f dev.yml exec django
      Execute a command in a running container

      Usage: exec [options] [-e KEY=VAL...] SERVICE COMMAND [ARGS...]

      Options:
      ....


      Where is my mistake? How can it be done better?



      As far as I can tell I've passed 4 args [dev, exec, django, sh] to the script, then within the script removed 3 (shift 3), therefore sh should have been left in the $@ var.










      share|improve this question
















      My script:



      #! /bin/bash --

      set -x

      ## docker-compose wrapper
      compose_fn()
      local ENV="$1"
      local VERB="$2"
      local SERVICE="$3"
      local CMD="docker-compose -f $ENV.yml"
      case "$VERB" in
      (exec)
      shift "$#" # remove args passed to this fn
      # Execute a command in a running container.
      if [ -n "$SERVICE" ]; then
      $CMD "$VERB" "$SERVICE" "$@"
      else
      echo "## Err: You must specify service name..."
      exit 1
      fi
      ;;
      esac


      compose_fn "$1" "$2" "$3"


      Is giving me a hard time with the following error:



      $ ./tst.sh dev exec django sh
      + compose_fn dev exec django
      + local ENV=dev
      + local VERB=exec
      + local SERVICE=django
      + local 'CMD=docker-compose -f dev.yml'
      + case "$VERB" in
      + shift 3
      + '[' -n django ']'
      + docker-compose -f dev.yml exec django
      Execute a command in a running container

      Usage: exec [options] [-e KEY=VAL...] SERVICE COMMAND [ARGS...]

      Options:
      ....


      Where is my mistake? How can it be done better?



      As far as I can tell I've passed 4 args [dev, exec, django, sh] to the script, then within the script removed 3 (shift 3), therefore sh should have been left in the $@ var.







      bash shell-script shell






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Apr 24 at 22:02







      NarūnasK

















      asked Apr 24 at 21:39









      NarūnasKNarūnasK

      9291723




      9291723




















          1 Answer
          1






          active

          oldest

          votes


















          11














          With shift "$#" you empty $@ completely. The $@ in the function is separate from the $@ in the main script. Since you know exactly how many elements of the script's $@ you need to use and shift off in the function, why don't you just pass all arguments to the function and then shift off the first three?



          #! /bin/bash --

          set -x

          ## docker-compose wrapper
          compose_fn()
          local env="$1"
          local verb="$2"
          local service="$3"

          local cmd=( docker-compose -f "$env.yml" )

          shift 3 # we've now used up three arguments

          case $verb in
          exec)
          # Execute a command in a running container.
          if [ -n "$service" ]; then
          "$cmd[@]" "$verb" "$service" "$@"
          else
          echo '## Err: You must specify service name...' >&2
          exit 1
          fi
          ;;
          *)
          printf 'Unknown verb: %sn' "$verb" >&2
          exit 1
          esac


          compose_fn "$@"


          I've also used lower-case variable names so that no system or special shell variables are used by accident (ENV is one that some shells uses under some circumstances, for example), and I've removed all unneeded quotes and curly braces.



          I've also put the command into an array, so that we can quote the YAML filename properly.



          You could also just move the setting of the three variables outside of the function, depending on what the rest of the script looks like and if this makes any sense at all. The three variables would then be global in the script.



          #! /bin/bash --

          set -x

          ## docker-compose wrapper
          compose_fn()
          local cmd=( docker-compose -f "$env.yml" )

          case $verb in
          exec)
          # Execute a command in a running container.
          if [ -n "$service" ]; then
          "$cmd[@]" "$verb" "$service" "$@"
          else
          echo '## Err: You must specify service name...' >&2
          exit 1
          fi
          ;;
          *)
          printf 'Unknown verb: %sn' "$verb" >&2
          exit 1
          esac


          env="$1"
          verb="$2"
          service="$3"

          shift 3

          compose_fn "$@"


          You may also bypass the [ -n "$service" ] test with



          service=$3:?'## Err: You must specify service name...'


          The parameter expansion $parameter:?word will exit the shell with the message defined by word if parameter is unset or empty. The bash shell would format this as



          script.sh: line 9: 3: ## Err: You must specify service name...


          Related:



          • When is double-quoting necessary?

          • How can we run a command stored in a variable?

          • Are there naming conventions for variables in shell scripts?





          share|improve this answer

























            Your Answer








            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "106"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f515342%2fpassing-args-from-the-bash-script-to-the-function-in-the-script%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            11














            With shift "$#" you empty $@ completely. The $@ in the function is separate from the $@ in the main script. Since you know exactly how many elements of the script's $@ you need to use and shift off in the function, why don't you just pass all arguments to the function and then shift off the first three?



            #! /bin/bash --

            set -x

            ## docker-compose wrapper
            compose_fn()
            local env="$1"
            local verb="$2"
            local service="$3"

            local cmd=( docker-compose -f "$env.yml" )

            shift 3 # we've now used up three arguments

            case $verb in
            exec)
            # Execute a command in a running container.
            if [ -n "$service" ]; then
            "$cmd[@]" "$verb" "$service" "$@"
            else
            echo '## Err: You must specify service name...' >&2
            exit 1
            fi
            ;;
            *)
            printf 'Unknown verb: %sn' "$verb" >&2
            exit 1
            esac


            compose_fn "$@"


            I've also used lower-case variable names so that no system or special shell variables are used by accident (ENV is one that some shells uses under some circumstances, for example), and I've removed all unneeded quotes and curly braces.



            I've also put the command into an array, so that we can quote the YAML filename properly.



            You could also just move the setting of the three variables outside of the function, depending on what the rest of the script looks like and if this makes any sense at all. The three variables would then be global in the script.



            #! /bin/bash --

            set -x

            ## docker-compose wrapper
            compose_fn()
            local cmd=( docker-compose -f "$env.yml" )

            case $verb in
            exec)
            # Execute a command in a running container.
            if [ -n "$service" ]; then
            "$cmd[@]" "$verb" "$service" "$@"
            else
            echo '## Err: You must specify service name...' >&2
            exit 1
            fi
            ;;
            *)
            printf 'Unknown verb: %sn' "$verb" >&2
            exit 1
            esac


            env="$1"
            verb="$2"
            service="$3"

            shift 3

            compose_fn "$@"


            You may also bypass the [ -n "$service" ] test with



            service=$3:?'## Err: You must specify service name...'


            The parameter expansion $parameter:?word will exit the shell with the message defined by word if parameter is unset or empty. The bash shell would format this as



            script.sh: line 9: 3: ## Err: You must specify service name...


            Related:



            • When is double-quoting necessary?

            • How can we run a command stored in a variable?

            • Are there naming conventions for variables in shell scripts?





            share|improve this answer





























              11














              With shift "$#" you empty $@ completely. The $@ in the function is separate from the $@ in the main script. Since you know exactly how many elements of the script's $@ you need to use and shift off in the function, why don't you just pass all arguments to the function and then shift off the first three?



              #! /bin/bash --

              set -x

              ## docker-compose wrapper
              compose_fn()
              local env="$1"
              local verb="$2"
              local service="$3"

              local cmd=( docker-compose -f "$env.yml" )

              shift 3 # we've now used up three arguments

              case $verb in
              exec)
              # Execute a command in a running container.
              if [ -n "$service" ]; then
              "$cmd[@]" "$verb" "$service" "$@"
              else
              echo '## Err: You must specify service name...' >&2
              exit 1
              fi
              ;;
              *)
              printf 'Unknown verb: %sn' "$verb" >&2
              exit 1
              esac


              compose_fn "$@"


              I've also used lower-case variable names so that no system or special shell variables are used by accident (ENV is one that some shells uses under some circumstances, for example), and I've removed all unneeded quotes and curly braces.



              I've also put the command into an array, so that we can quote the YAML filename properly.



              You could also just move the setting of the three variables outside of the function, depending on what the rest of the script looks like and if this makes any sense at all. The three variables would then be global in the script.



              #! /bin/bash --

              set -x

              ## docker-compose wrapper
              compose_fn()
              local cmd=( docker-compose -f "$env.yml" )

              case $verb in
              exec)
              # Execute a command in a running container.
              if [ -n "$service" ]; then
              "$cmd[@]" "$verb" "$service" "$@"
              else
              echo '## Err: You must specify service name...' >&2
              exit 1
              fi
              ;;
              *)
              printf 'Unknown verb: %sn' "$verb" >&2
              exit 1
              esac


              env="$1"
              verb="$2"
              service="$3"

              shift 3

              compose_fn "$@"


              You may also bypass the [ -n "$service" ] test with



              service=$3:?'## Err: You must specify service name...'


              The parameter expansion $parameter:?word will exit the shell with the message defined by word if parameter is unset or empty. The bash shell would format this as



              script.sh: line 9: 3: ## Err: You must specify service name...


              Related:



              • When is double-quoting necessary?

              • How can we run a command stored in a variable?

              • Are there naming conventions for variables in shell scripts?





              share|improve this answer



























                11












                11








                11







                With shift "$#" you empty $@ completely. The $@ in the function is separate from the $@ in the main script. Since you know exactly how many elements of the script's $@ you need to use and shift off in the function, why don't you just pass all arguments to the function and then shift off the first three?



                #! /bin/bash --

                set -x

                ## docker-compose wrapper
                compose_fn()
                local env="$1"
                local verb="$2"
                local service="$3"

                local cmd=( docker-compose -f "$env.yml" )

                shift 3 # we've now used up three arguments

                case $verb in
                exec)
                # Execute a command in a running container.
                if [ -n "$service" ]; then
                "$cmd[@]" "$verb" "$service" "$@"
                else
                echo '## Err: You must specify service name...' >&2
                exit 1
                fi
                ;;
                *)
                printf 'Unknown verb: %sn' "$verb" >&2
                exit 1
                esac


                compose_fn "$@"


                I've also used lower-case variable names so that no system or special shell variables are used by accident (ENV is one that some shells uses under some circumstances, for example), and I've removed all unneeded quotes and curly braces.



                I've also put the command into an array, so that we can quote the YAML filename properly.



                You could also just move the setting of the three variables outside of the function, depending on what the rest of the script looks like and if this makes any sense at all. The three variables would then be global in the script.



                #! /bin/bash --

                set -x

                ## docker-compose wrapper
                compose_fn()
                local cmd=( docker-compose -f "$env.yml" )

                case $verb in
                exec)
                # Execute a command in a running container.
                if [ -n "$service" ]; then
                "$cmd[@]" "$verb" "$service" "$@"
                else
                echo '## Err: You must specify service name...' >&2
                exit 1
                fi
                ;;
                *)
                printf 'Unknown verb: %sn' "$verb" >&2
                exit 1
                esac


                env="$1"
                verb="$2"
                service="$3"

                shift 3

                compose_fn "$@"


                You may also bypass the [ -n "$service" ] test with



                service=$3:?'## Err: You must specify service name...'


                The parameter expansion $parameter:?word will exit the shell with the message defined by word if parameter is unset or empty. The bash shell would format this as



                script.sh: line 9: 3: ## Err: You must specify service name...


                Related:



                • When is double-quoting necessary?

                • How can we run a command stored in a variable?

                • Are there naming conventions for variables in shell scripts?





                share|improve this answer















                With shift "$#" you empty $@ completely. The $@ in the function is separate from the $@ in the main script. Since you know exactly how many elements of the script's $@ you need to use and shift off in the function, why don't you just pass all arguments to the function and then shift off the first three?



                #! /bin/bash --

                set -x

                ## docker-compose wrapper
                compose_fn()
                local env="$1"
                local verb="$2"
                local service="$3"

                local cmd=( docker-compose -f "$env.yml" )

                shift 3 # we've now used up three arguments

                case $verb in
                exec)
                # Execute a command in a running container.
                if [ -n "$service" ]; then
                "$cmd[@]" "$verb" "$service" "$@"
                else
                echo '## Err: You must specify service name...' >&2
                exit 1
                fi
                ;;
                *)
                printf 'Unknown verb: %sn' "$verb" >&2
                exit 1
                esac


                compose_fn "$@"


                I've also used lower-case variable names so that no system or special shell variables are used by accident (ENV is one that some shells uses under some circumstances, for example), and I've removed all unneeded quotes and curly braces.



                I've also put the command into an array, so that we can quote the YAML filename properly.



                You could also just move the setting of the three variables outside of the function, depending on what the rest of the script looks like and if this makes any sense at all. The three variables would then be global in the script.



                #! /bin/bash --

                set -x

                ## docker-compose wrapper
                compose_fn()
                local cmd=( docker-compose -f "$env.yml" )

                case $verb in
                exec)
                # Execute a command in a running container.
                if [ -n "$service" ]; then
                "$cmd[@]" "$verb" "$service" "$@"
                else
                echo '## Err: You must specify service name...' >&2
                exit 1
                fi
                ;;
                *)
                printf 'Unknown verb: %sn' "$verb" >&2
                exit 1
                esac


                env="$1"
                verb="$2"
                service="$3"

                shift 3

                compose_fn "$@"


                You may also bypass the [ -n "$service" ] test with



                service=$3:?'## Err: You must specify service name...'


                The parameter expansion $parameter:?word will exit the shell with the message defined by word if parameter is unset or empty. The bash shell would format this as



                script.sh: line 9: 3: ## Err: You must specify service name...


                Related:



                • When is double-quoting necessary?

                • How can we run a command stored in a variable?

                • Are there naming conventions for variables in shell scripts?






                share|improve this answer














                share|improve this answer



                share|improve this answer








                edited Apr 25 at 7:10

























                answered Apr 24 at 22:12









                KusalanandaKusalananda

                144k18272450




                144k18272450



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Unix & Linux Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f515342%2fpassing-args-from-the-bash-script-to-the-function-in-the-script%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Sum ergo cogito? 1 nng

                    三茅街道4182Guuntc Dn precexpngmageondP