Mrthdrb

I am trying to use different e-mail template for one of my custom order status when the status is changed from the admin.

I have used the event sales_order_save_after

<observer name="sales_order_save_after" instance="HawkOrderFlowObserverSalesOrderSalesOrderAfterSave"/>

And created an observer like follows:

<?php

namespace HawkOrderFlowObserverSalesOrder;

use MagentoFrameworkEventObserver as EventObserver;
use MagentoFrameworkEventObserverInterface;

class SalesOrderAfterSave implements ObserverInterface 

/**
 * @var MagentoFrameworkAppRequestHttp
 */
protected $_request;

/**
 * @var MagentoFrameworkMailTemplateTransportBuilder
 */
protected $_transportBuilder;

/**
 * @var MagentoStoreModelStoreManagerInterface
 */
protected $_storeManager;

/**
 * For logger, var/log
 */
protected $_logger;


public function __construct(
 MagentoFrameworkAppActionContext $context,
 MagentoFrameworkAppRequestHttp $request,
 MagentoFrameworkMailTemplateTransportBuilder $transportBuilder,
 MagentoStoreModelStoreManagerInterface $storeManager,
 PsrLogLoggerInterface $logger
) 
 $this->_request = $request;
 $this->_transportBuilder = $transportBuilder;
 $this->_storeManager = $storeManager;
 $this->_logger = $logger;


public function execute(MagentoFrameworkEventObserver $observer)



 $order = $observer->getEvent()->getOrder();
 $lastOrderId = $order->getId();
 $orderStatus = $order->getStatus();

 try 

 if($orderStatus == "viewed_by_admin") 
 $store = $this->_storeManager->getStore()->getId();
 $template = $this->_transportBuilder->setTemplateIdentifier('13') //Where 13 is the Email Template ID created in the admin pannel under the Stores -> Email Templates
 ->setTemplateOptions(['area' => 'frontend', 'store' => $store]);
 return $template;
 

 catch (Exception $e) 
 $this->_logger->critical($e->getMessage());
 return;
 
 

Still not using my defined email template rather then still using the default email template from admin configuration, Is there anything I am missing here please guide about it.

Any help will be appreciated.

It is good and you followed good approach as per M2 standards. It needs some improvement to make it compatible and error-free in a maximum of cases

1. Exception Handling.
   $order = $observer->getEvent()->getOrder(); if( !empty($order) ) // do code here




2. Naming convention. Do use camel-case for variables. $order_status should be $orderStatus.



3. It is observer so you won't be able to track if that happened or not so do wrap it in try-catch and log accordingly ( do add a check if logs are enabled or not ).